mirror of
git://git.openembedded.org/meta-openembedded
synced 2026-01-01 13:58:06 +00:00
Revert "protobuf: stage protoc binary to sysroot"
This reverts commita0557fe543. As said by Ross[Ø]: "Putting the _target_ protoc into the sysroot for executation at _build_ time isn't useful because even if it has the right architecture, the tune might be incompatible. Recipes which want protoc should just depend on protobuf-native." This has been reverted recently by Samuli[1]: "If protoc is enabled for the build, recipes using protobuf will fail when protoc is not available in the recipe sysroot" Be the revert is incorret as This is an issue coming from qtgrpc other recipes that use protobuf or gRPC compiler, proplery looks for the binary in the correct sysroot folder. Qtgrpc recipe should fix this issue at the recipe level, for example this is what I've done for "etcd-cpp-apiv3" recipe[2] that doesn't need this patch to properly compile. So keeping this hack doesn't seems to be a correct fix. Note that qtgrpc recipe isn't available on meta-oe nor any other public layers. 0: https://patchwork.yoctoproject.org/project/oe/patch/20230904161230.377450-1-ross.burton@arm.com/ 1: https://patchwork.yoctoproject.org/project/oe/patch/20230927051101.3088498-1-samuli.piippo@qt.io/ 2:47f0d9e032CC: Samuli Piippo <samuli.piippo@gmail.com> CC: Ross Burton <ross.burton@arm.com> Signed-off-by: Clément Péron <peron.clem@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> (cherry picked from commitbfb626a230) Signed-off-by: Armin Kuster <akuster808@gmail.com>
This commit is contained in:
parent
d01994d26b
commit
35edaebc55
|
|
@ -101,9 +101,6 @@ PACKAGE_BEFORE_PN = "${PN}-compiler ${PN}-lite"
|
|||
FILES:${PN}-compiler = "${bindir} ${libdir}/libprotoc${SOLIBS}"
|
||||
FILES:${PN}-lite = "${libdir}/libprotobuf-lite${SOLIBS}"
|
||||
|
||||
# CMake requires binaries to exist in sysroot, even if they have wrong architecture.
|
||||
SYSROOT_DIRS += "${bindir}"
|
||||
|
||||
RDEPENDS:${PN}-compiler = "${PN}"
|
||||
RDEPENDS:${PN}-dev += "${PN}-compiler"
|
||||
RDEPENDS:${PN}-ptest = "bash ${@bb.utils.contains('PACKAGECONFIG', 'python', 'python3-protobuf', '', d)}"
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user