From 3fd372d79b400569ed09c68735c25c87bd476135 Mon Sep 17 00:00:00 2001 From: Corentin Guillevic Date: Fri, 10 Oct 2025 17:29:35 +0200 Subject: [PATCH] libblockdev: improve reproducibility The --with-smart option behind the feature "smart" relies on the drivedb.h header, provided by smartmontools package (/usr/share/smartmontools/drivedb.h). However the dependencies (DEPENDS) miss this package. Furthermore, if the --with-drivedb option is not used, the configuration step will search for the file first on the host's rootfs. This may result in the wrong header being picked, or the --with-smart option being silently disabled due to incomplete dependencies (causing missing header). The header is now guaranteed to be present due to an added dependency in the "smart" feature, and its location is specified by the --with-drivedb option. Signed-off-by: Corentin Guillevic Signed-off-by: Khem Raj --- meta-oe/recipes-extended/libblockdev/libblockdev_3.2.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta-oe/recipes-extended/libblockdev/libblockdev_3.2.1.bb b/meta-oe/recipes-extended/libblockdev/libblockdev_3.2.1.bb index 48e6971d1a..e4078d6862 100644 --- a/meta-oe/recipes-extended/libblockdev/libblockdev_3.2.1.bb +++ b/meta-oe/recipes-extended/libblockdev/libblockdev_3.2.1.bb @@ -35,7 +35,7 @@ PACKAGECONFIG[crypto] = "--with-crypto,--without-crypto,cryptsetup keyutils nss PACKAGECONFIG[mdraid] = "--with-mdraid,--without-mdraid,libbytesize" PACKAGECONFIG[mpath] = "--with-mpath,--without-mpath, multipath-tools, lvm2" PACKAGECONFIG[tools] = "--with-tools,--without-tools,libbytesize libdevmapper" -PACKAGECONFIG[smart] = "--with-smart,--without-smart,libatasmart" +PACKAGECONFIG[smart] = "--with-smart --with-drivedb=${RECIPE_SYSROOT}${datadir}/smartmontools,--without-smart,libatasmart smartmontools" PACKAGECONFIG[smartmontools] = "--with-smartmontools,--without-smartmontools,json-glib,smartmontools" export GIR_EXTRA_LIBS_PATH = "${B}/src/utils/.libs"