From 4a05d9a185df41e3b84f4d821db831836fa77e8d Mon Sep 17 00:00:00 2001 From: Johannes Schneider Date: Fri, 1 Nov 2024 13:05:14 +0100 Subject: [PATCH] signing.bbclass: add label length check Add a (more helpful) error message in case the Package-Name exceeds a certain length which would have the softhsm tools error out. The $PN is used as 'label' in the softhsm, which is a "CK_UTF8CHAR paddedLabel[32]" in softhsm2-util.cpp, so it must not be longer. Signed-off-by: Johannes Schneider Signed-off-by: Khem Raj --- meta-oe/classes/signing.bbclass | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/meta-oe/classes/signing.bbclass b/meta-oe/classes/signing.bbclass index 7fd167d937..8af7bbf8e0 100644 --- a/meta-oe/classes/signing.bbclass +++ b/meta-oe/classes/signing.bbclass @@ -92,6 +92,11 @@ signing_pkcs11_tool() { } signing_import_prepare() { + # the $PN is used as 'label' in the softhsm, which is a "CK_UTF8CHAR + # paddedLabel[32]" in softhsm2-util.cpp, so it must not be longer. + LEN=$(echo -n ${PN} | wc -c) + test $LEN -le 32 || bbfatal "PN must not have a length greater than 32 chars." + export _SIGNING_ENV_FILE_="${B}/meta-signing.env" rm -f "$_SIGNING_ENV_FILE_"