CaROS/meta-openembedded
3
1
Fork 0
mirror of git://git.openembedded.org/meta-openembedded synced 2026-01-01 13:58:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

xarchiver: Upstream printf-fix-patch

Browse Source 
Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
This commit is contained in:
Andreas Müller 2017-04-12 17:50:59 +02:00 committed by Martin Jansa
parent 33b05cc85b
commit 6dc31ce48b
2 changed files with 2 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
meta-xfce/recipes-apps/xarchiver/xarchiver/0001-Add-proper-formatting-string-to-printf-like-function.patch
View File

@ -1,40 +0,0 @@
From baf93ea9acf845c5455d577ac19a6f680dac3d2d Mon Sep 17 00:00:00 2001
From: Khem Raj <raj.khem@gmail.com>
Date: Thu, 30 Mar 2017 11:22:42 -0700
Subject: [PATCH] Add proper formatting string to printf-like functions
Avoids potential security holes and makes compiler happy
| ../../../../../../../workspace/sources/xarchiver/src/window.c:236:72: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
| gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),message2);
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
src/window.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: git/src/window.c
===================================================================
--- git.orig/src/window.c
+++ git/src/window.c
@@ -231,9 +231,9 @@ int xa_show_message_dialog (GtkWindow *w
{
int response;
- dialog = gtk_message_dialog_new (window,mode,type,button,message1);
+ dialog = gtk_message_dialog_new (window,mode,type,button,"%s",message1);
gtk_dialog_set_default_response (GTK_DIALOG (dialog),GTK_RESPONSE_NO);
- gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),message2);
+ gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),"%s",message2);
response = gtk_dialog_run (GTK_DIALOG (dialog));
gtk_widget_destroy (GTK_WIDGET (dialog));
return response;
@@ -511,7 +511,7 @@ void xa_list_archive (GtkMenuItem *menui
g_fprintf (stream,_("Comment:\n"));
if (bp)
g_fprintf(stream,"</b><pre>");
- g_fprintf (stream,archive[idx]->comment->str);
+ g_fprintf (stream,"%s",archive[idx]->comment->str);
if (bp)
g_fprintf(stream,"</pre>");
g_fprintf (stream,"\n");

6
meta-xfce/recipes-apps/xarchiver/xarchiver_git.bb
View File

@ -7,10 +7,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
DEPENDS = "gtk+ glib-2.0 xfce4-dev-tools-native intltool-native"
SRC_URI = "git://github.com/schnitzeltony/xarchiver.git;branch=master \
file://0001-Add-proper-formatting-string-to-printf-like-function.patch \
"
SRCREV = "e80e90528c9aab2fe36d9078b945b44c05cc20d3"
SRC_URI = "git://github.com/schnitzeltony/xarchiver.git;branch=master"
SRCREV = "5a26dd8ceab0af71b30c83286d7c7398a858c814"
PV = "0.5.3"
S = "${WORKDIR}/git"