mirror of
git://git.yoctoproject.org/meta-selinux
synced 2026-01-01 13:58:04 +00:00
libselinux: Backport NULL pointer fix from 3.1
Using function restorecon_init inside selinux_restorecon.c can
result in a NULL pointer. This happens because function
selinux_restorecon_set_sehandle can return a NULL pointer. But
it is not checked and directly given to the next function.
This problem is already fixed in libselinux 3.1 and above.
Therefore backport this fix.
Upstream-Status: Backport [08f5e30177]
Issue: MGURSU-7259
Change-Id: Ice5c7c94987441ba53431aeffc200c0b9c5697a4
Signed-off-by: Joe MacDonald <joe@deserted.net>
This commit is contained in:
parent
10187c3cee
commit
d6ff5a0e67
|
|
@ -0,0 +1,30 @@
|
|||
From 08f5e30177218fae7ce9f5c8d6856690126b2b30 Mon Sep 17 00:00:00 2001
|
||||
From: Ji Qin <jiqin.ji@huawei.com>
|
||||
Date: Sun, 14 Jun 2020 21:20:23 -0400
|
||||
Subject: [PATCH] libselinux: Fix NULL pointer use in
|
||||
selinux_restorecon_set_sehandle
|
||||
|
||||
error occur when selinux_restorecon_default_handle return NULL in
|
||||
restorecon_init.
|
||||
|
||||
fixes: https://github.com/SELinuxProject/selinux/issues/249
|
||||
|
||||
Signed-off-by: Ji Qin <jiqin.ji@huawei.com>
|
||||
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
|
||||
---
|
||||
libselinux/src/selinux_restorecon.c | 2 ++
|
||||
1 file changed, 2 insertions(+)
|
||||
|
||||
diff --git a/libselinux/src/selinux_restorecon.c b/libselinux/src/selinux_restorecon.c
|
||||
index d1ce830c5..6993be6fd 100644
|
||||
--- a/libselinux/src/selinux_restorecon.c
|
||||
+++ b/libselinux/src/selinux_restorecon.c
|
||||
@@ -1154,6 +1154,8 @@ void selinux_restorecon_set_sehandle(struct selabel_handle *hndl)
|
||||
size_t num_specfiles, fc_digest_len;
|
||||
|
||||
fc_sehandle = (struct selabel_handle *) hndl;
|
||||
+ if (!fc_sehandle)
|
||||
+ return;
|
||||
|
||||
/* Check if digest requested in selabel_open(3), if so use it. */
|
||||
if (selabel_digest(fc_sehandle, &fc_digest, &fc_digest_len,
|
||||
|
|
@ -12,4 +12,5 @@ SRC_URI += "\
|
|||
file://libselinux-make-SOCK_CLOEXEC-optional.patch \
|
||||
file://libselinux-define-FD_CLOEXEC-as-necessary.patch \
|
||||
file://0001-Fix-building-against-musl-and-uClibc-libc-libraries.patch \
|
||||
file://0001-Fix-NULL-pointer-use-in-selinux_restorecon_set_sehandle.patch \
|
||||
"
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user