CaROS/poky
3
1
Fork 0
mirror of https://git.yoctoproject.org/git/poky synced 2026-01-01 13:58:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

selftest/bbtests: Add tests for git floating tag resolution

Browse Source 
This test ensures that where a floating tag is used for a git url, there
aren't a number of different bugs such as inconsistent source revisions
for the tag within a given build and that the recipe is reparsed at each
run to ensure the tag is checked.

A test is also added to ensure that the build fails if SRCPV (get_srcrev())
isn't used yet there is a floating tag.

(From OE-Core rev: 33554ba3c034fc31744b27392afe751d645d6c2e)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Richard Purdie 2022-02-10 13:44:22 +00:00
parent 383ade4e3c
commit ae00fcd638
3 changed files with 45 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
meta-selftest/recipes-test/gitunpackoffline/gitunpackoffline-fail.bb Normal file
View File

@ -0,0 +1,16 @@
SUMMARY = "Test recipe for fetching git submodules"
HOMEPAGE = "https://git.yoctoproject.org/git/matchbox-panel-2"
LICENSE = "GPL-2.0-or-later"
LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
INHIBIT_DEFAULT_DEPS = "1"
TAGVALUE = "2.10"
# Deliberately have a tag which has to be resolved but ensure do_unpack doesn't access the network again.
SRC_URI = "git://git.yoctoproject.org/git/matchbox-panel-2;branch=master;protocol=https"
SRC_URI:append:gitunpack-enable-recipe = ";tag=${TAGVALUE}"
SRCREV = "f82ca3f42510fb3ef10f598b393eb373a2c34ca7"
SRCREV:gitunpack-enable-recipe = ""
S = "${WORKDIR}/git"

5
meta-selftest/recipes-test/gitunpackoffline/gitunpackoffline.bb Normal file
View File

@ -0,0 +1,5 @@
require gitunpackoffline-fail.bb
TAGVALUE = "2.11"
PV = "0.0+git${SRCPV}"

24
meta/lib/oeqa/selftest/cases/bbtests.py
View File

@ -312,3 +312,27 @@ INHERIT:remove = \"report-error\"
self.assertFalse(fatal, "Failed to patch using PATCHTOOL=\"git\"")
self.delete_recipeinc(test_recipe)
bitbake('-cclean man-db')
def test_git_unpack_nonetwork(self):
"""
Test that a recipe with a floating tag that needs to be resolved upstream doesn't
access the network in a patch task run in a separate builld invocation
"""
# Enable the recipe to float using a distro override
self.write_config("DISTROOVERRIDES .= \":gitunpack-enable-recipe\"")
bitbake('gitunpackoffline -c fetch')
bitbake('gitunpackoffline -c patch')
def test_git_unpack_nonetwork_fail(self):
"""
Test that a recipe with a floating tag which doesn't call get_srcrev() in the fetcher
raises an error when the fetcher is called.
"""
# Enable the recipe to float using a distro override
self.write_config("DISTROOVERRIDES .= \":gitunpack-enable-recipe\"")
result = bitbake('gitunpackoffline-fail -c fetch', ignore_status=True)
self.assertTrue("Recipe uses a floating tag/branch without a fixed SRCREV" in result.output, msg = "Recipe without PV set to SRCPV should have failed: %s" % result.output)