Only emit warning on clang if bpf is actually in PACKAGECONFIG.
Signed-off-by: Scott Branden <scott.branden@broadcom.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
To fix the following build failures
turbostat.c:(.text+0xc28a): undefined reference to `UL'
turbostat.c:33:10: fatal error: sys/capability.h: No such file or directory (for kernel v5.6-rc7)
- Add dependency on libcap for kernel v5.6-rc7 and later versions
- Copy internal linux/const.h used by previously added internal linux/bits.h
- Tweak linux/const.h to allow it to refer to uapi const.h, as
linux-libc-headers purposely removes _UAPI from the locker macros of the
headers
- Remove -I for kernel-source in EXTRA_OEMAKE, as linux-kernel-headers has
provided enough and necessary headers
- Make do_configure depend on kernel's do_shared_workdir
Signed-off-by: He Zhe <zhe.he@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Remove -m32 from CFLAGS even for -cross recipe. Also remove
${GDB_CONF_FLAGS} from GDB_TARGET variable (that is passed to the gdb
configuration) since the use of GDB_CONF_FLAGS is removed by
0001-cross_add_configure_option.patch.
Signed-off-by: Goran Cengic <cengic@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This patch is the other part of the fixes for CVE-2020-5208.
Signed-off-by: Wenlin Kang <wenlin.kang@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
A timestamp was getting encoded into the gzip header. This
causes multilib conflicts when installed together, and would
likely fail reproducablity tests.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
refresh the following patch:
0002-kpatch-build-allow-overriding-of-distro-name.patch
Signed-off-by: Wang Mingyu <wangmy@cn.fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
refresh the following patch:
0001-makedumpfile-replace-hardcode-CFLAGS.patch
0003-build-Delete-libebl-from-required-libraries-during-l.patch
removed since it is included in 1.6.7
Signed-off-by: Wang Mingyu <wangmy@cn.fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Allows for testing SPI interface using spidev driver and is part of the
kernel tools.
Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
Reviewed-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
Tested-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
Signed-off-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
5.4 kernel exposes a problem, where its using host includes to compile
BPF tests and it fails for mips because ptrace.h is quite different so
it can not find the needed pt_struct definitions during cross compile
% clang -fno-stack-protector -I. -I./include/uapi -I../../../include/uapi -I/mnt/b/yoe/build/tmp/work/qemumips-yoe-linux/kernel-selft
est/1.0-r0/kernel-selftest-1.0/tools/testing/selftests/bpf/../usr/include -D__TARGET_ARCH_mips -g -idirafter /mnt/b/yoe/build/tmp/wor
k/qemumips-yoe-linux/kernel-selftest/1.0-r0/recipe-sysroot-native/usr/lib/clang/10.0.0/include -Wno-compare-distinct-pointer-types -O2 -target bpf -emit-llvm \
-c progs/loop1.c
progs/loop1.c:21:9: error: no member named 'regs' in 'struct pt_regs'
m = PT_REGS_RC(ctx);
^~~~~~~~~~~~~~~
./bpf_helpers.h:466:29: note: expanded from macro 'PT_REGS_RC'
~~ ^ 1 error generated.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This seems to be not needed as link succeeds without this library,
moreover this is static-only library in latest elfutils
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Alexander Kanavin <alex.kanavin@gmail.com>
This release has python3 support so updating python3 to RDEPENDS.
python subprocess comes with python3-core, so removing from RDEPENDS.
Removed patch, which is already merged in this release.
Signed-off-by: Naveen Saini <naveen.kumar.saini@intel.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This gives users a proper error message when trying to build
a known non-building package.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
selftests do not support it and clang from meta-clang builds with this
turned on by default
Disable security flags completely, drop all workarounds used to get
around the hoop
Signed-off-by: Khem Raj <raj.khem@gmail.com>
We do not pass CFLAGS to build and fortify sources needs some
optimization to be enabled, its better to reset the additional flags and
let the build system add them as it needs
Fixes build failures like
tools/include/tools/libc_compat.h:11:21: error: static declaration of 'reallocarray' follows non-static declaration
| 11 | static inline void *reallocarray(void *ptr, size_t nmemb, size_t size)
| | ^~~~~~~~~~~~
Signed-off-by: Khem Raj <raj.khem@gmail.com>
If not passed then it computes arch from `uname`
and uname will be wrong on cross compiles when target != host
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This patch fixes next QA Issue:
nativesdk-kpatch: Files/directories were installed but not shipped in any package:
/etc
/etc/init
/etc/init/kpatch.conf
Signed-off-by: Ruslan Bilovol <rbilovol@cisco.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Time format in dmesg has been changed from "%Y-%m-%d %H:%M:%S" to
"%Y-%m-%dT%H:%M:%S", backport an upstream patch to fix this error.
Signed-off-by: Liwei Song <liwei.song@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
* now with virtual/kernel dependency dropped we don't want to depend on kernel signature just for
this RRECOMMENDS
* fixes:
=== Comparing signatures for task do_package_write_ipk.sigdata between hammerhead and mako ===
ERROR: oprofile different signature for task do_package_write_ipk.sigdata between hammerhead and mako
NOTE: Starting bitbake server...
runtaskdeps changed:
['binutils/binutils_2.32.bb.do_packagedata', -linux/linux-lg-hammerhead_git.bb.do_packagedata, +linux/linux-lg-mako_git.bb.do_packagedata, 'opkg-utils/opkg-utils_0.4.1.bb.do_populate_sysroot:virtual:native oprofile/oprofile_1.3.0.bb.do_package oprofile/oprofile_1.3.0.bb.do_packagedata pseudo/pseudo_git.bb.do_populate_sysroot:virtual:native xz/xz_5.2.4.bb.do_populate_sysroot:virtual:native']
linux/linux-lg-hammerhead_git.bb.do_packagedata with hash 0c5215deb4737611ad413f57cf5fbdef8a9b2cc6d04035f754a4e93fb38f61d1
changed to
linux/linux-lg-mako_git.bb.do_packagedata with hash 0f3b34773ca3e590739754c25959feb7cdcd67cf7904ac7fe6cc535e8d6519a8
Dependency on task linux/linux-lg-mako_git.bb.do_packagedata was added with hash 0f3b34773ca3e590739754c25959feb7cdcd67cf7904ac7fe6cc535e8d6519a8
Dependency on task linux/linux-lg-hammerhead_git.bb.do_packagedata was removed with hash 0c5215deb4737611ad413f57cf5fbdef8a9b2cc6d04035f754a4e93fb38f61d1
ERROR: 1 errors found in /home/jenkins/workspace/luneos-unstable/webos-ports/tmp-glibc/sstate-diff/1563368432/signatures.mako.do_package_write_ipk.sigdata.log
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This recipe depends on 'virtual/kernel', so it should
be MACHINE_ARCH.
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
* the kernel dependency was added couple years ago with:
https://git.openembedded.org/openembedded-core/commit/?id=16bc366877a2e02d96adb91b90e30710777e6f09
the reasons for it no longer seem valid as it build ok
without the dependency
* there as some differences in the resulting binaries (built with and without
kernel dependency):
docker-shr qemux86-64@ ~/build/oe-core $ diff -rq tmp-glibc/work/*/oprofile/*/image
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/ocount and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/ocount differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/opannotate and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/opannotate differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/oparchive and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/oparchive differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/operf and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/operf differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/opgprof and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/opgprof differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/ophelp and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/ophelp differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/opimport and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/opimport differ
Files tmp-glibc/work/core2-64-oe-linux/oprofile/1.3.0-r0-without-kernel-dep/image/usr/bin/opreport and tmp-glibc/work/qemux86_64-oe-linux/oprofile/1.3.0-r0-with-kernel-dep/image/usr/bin/opreport differ
* comparing the first one with diffoscope shows only 2 insignificant changes:
- GNU 0x00000014 NT_GNU_BUILD_ID (unique build ID bitstring) Build ID: 71d68718f2b1393cce55605691453ca0615a985d
+ GNU 0x00000014 NT_GNU_BUILD_ID (unique build ID bitstring) Build ID: 3b6d2e8b3ce02b99a41e594fafb756e5648edd3c
- 0x0041ab00 31203230 31390032 323a3334 3a333100 1 2019.22:34:31.
+ 0x0041ab00 31203230 31390032 323a3239 3a303600 1 2019.22:29:06.
* similarly for other binaries
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Since commit [21f84fc insane: add sanity checks to SRC_URI] applied
in oe-core, do not use unstable github archive tarballs
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
because bits.h was included in msr-index.h, so we also need
copy bits.h from kernel to tubostat to aviod compile error.
Signed-off-by: Liwei Song <liwei.song@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This tool suite is designed to assist kernel and OS developers
in optimizing their linux stack's suspend/resume & boot time.
For more details and usage, please check:
https://01.org/pm-graph
Signed-off-by: Naveen Saini <naveen.kumar.saini@intel.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
* fixes:
ERROR: oprofile different signature for task do_configure.sigdata between hammerhead and mako
Hash for dependent task oprofile/oprofile_1.3.0.bb.do_prepare_recipe_sysroot changed from deecd34bc94f47935ce3dc7f83f9a8407269959e446518bd9700a2ebae4324bb to d4d6301a72fcd061c167a6715372a6e35f57bf08152a6223b1571957834428f0
Unable to find matching sigdata for /OE/build/luneos-master/webos-ports/meta-openembedded/meta-oe/recipes-kernel/oprofile/oprofile_1.3.0.bb.do_prepare_recipe_sysroot with hashes deecd34bc94f47935ce3dc7f83f9a8407269959e446518bd9700a2ebae4324bb or d4d6301a72fcd061c167a6715372a6e35f57bf08152a6223b1571957834428f0
$ bitbake-diffsigs /OE/build/luneos-master/webos-ports/tmp-glibc/sstate-diff/1557963509/[hm]*/*/oprofile/*do_prepare*.sigdata*
runtaskdeps changed:
['autoconf/autoconf_2.69.bb.do_populate_sysroot:virtual:native automake/automake_1.16.1.bb.do_populate_sysroot:virtual:native binutils/binutils_2.32.bb.do_populate_sysroot gcc/gcc-cross_7.3.bb.do_populate_sysroot gcc/gcc-runtime_7.3.bb.do_populate_sysroot glibc/glibc_2.29.bb.do_populate_sysroot gnu-config/gnu-config_git.bb.do_populate_sysroot:virtual:native libtool/libtool-cross_2.4.6.bb.do_populate_sysroot libtool/libtool-native_2.4.6.bb.do_populate_sysroot', -linux/linux-lg-hammerhead_git.bb.do_populate_sysroot, +linux/linux-lg-mako_git.bb.do_populate_sysroot, 'oprofile/oprofile_1.3.0.bb.do_fetch pkgconfig/pkgconfig_git.bb.do_populate_sysroot:virtual:native popt/popt_1.16.bb.do_populate_sysroot']
linux/linux-lg-hammerhead_git.bb.do_populate_sysroot with hash e58e94601af73831ea51ca6cc18578c26b9b491bcadb82a2c590b22498447438
changed to
linux/linux-lg-mako_git.bb.do_populate_sysroot with hash 4c7372d0063be9d5c96bfad20a2052ded3a7121a06027c21a75e79a4f6a678e3
Dependency on task linux/linux-lg-mako_git.bb.do_populate_sysroot was added with hash 4c7372d0063be9d5c96bfad20a2052ded3a7121a06027c21a75e79a4f6a678e3
Dependency on task linux/linux-lg-hammerhead_git.bb.do_populate_sysroot was removed with hash e58e94601af73831ea51ca6cc18578c26b9b491bcadb82a2c590b22498447438
* as detected with:
openembedded-core/scripts/sstate-diff-machines.sh --targets=world --tmpdir=tmp-glibc/ --analyze --machines="hammerhead mako qemux86"
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
bpftool is a 'special' recipe since it does "inherit kernelsrc", like
perf in oe-core or cpupower in meta-oe.
they don't have their own sources, but reuse the kernel source tree,
from virtual/kernel recipe. As such, checking the license file does
not seem relevant, since the fetching (and license check) is deferred
to the virtual/kernel recipe.
Remove LIC_FILES_CHKSUM like it is done in perf and cpupower.
Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
cpupower is a 'special' recipe since it does "inherit kernelsrc" ,
which essentially means that it doesn't have its own sources, but
reuse the kernel source tree, from virtual/kernel recipe. As such,
checking the license file in cpupower recipe does not seem relevant,
since it does not fetch anything (kernelsrc has "deltask do_fetch")
and the fetching is deferred to the virtual/kernel recipe.
so we are basically checking the COPYING file twice. If there was any
license issue, it would have been caught by virtual/kernel recipe
already.
Hence we remove LIC_FILES_CHKSUM like it is done for perf recipe in
OE-core in meta/recipes-kernel/perf/perf.bb.
It has the nice side effect that BSP layers can use different kernel
versions without worrying about any LICENSE checksum changes in
between kernel versions.
Reported-by: Daniel Díaz <daniel.diaz@linaro.org>
Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Fixes
ERROR: QA Issue: cpupower: Files/directories were installed but not shipped in any package:
/usr/share/bash-completion
/usr/share/bash-completion/completions
/usr/share/bash-completion/completions/cpupower
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This upgrade fixed the below issue:
When run '$makedumpfile -E -d 1 /proc/vmcore /root/vmcore_dumpfile'
shows 'The kernel version is not supported.'
Signed-off-by: Haiqing Bai <Haiqing.Bai@windriver.com>
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
A couple have still been missed in the past despite multiple
attempts at doing so (or simply have re-appeared?).
Search & replace made using the following command:
sed -e 's|\(d\.getVar \?\)( \?\([^,()]*\), \?True)|\1(\2)|g' \
-i $(git grep -E 'getVar ?\( ?([^,()]*), ?True\)' \
| cut -d':' -f1 \
| sort -u)
Signed-off-by: André Draszik <andre.draszik@jci.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
- Drop upstreamed patch
- Update COPYING file checksum: the copyright date changes
and there is a convertion to SPDX Format.
Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Even running on 32bit the bpf objects are 64bit: this triggers the QA about
bitsize mismatch 32 vs. 64. Besides, objdump does not recognize the arch 0xf7.
Trying the workaround to use the llvm-objdump and setting TOOLCHAIN = "clang"
the build for arm fails on libcxx
|include/c++/8.2.0/atomic:250: undefined reference to `__atomic_load_4'
Temporary disable bpf as done for x86/32bit as it seems still unstable.
Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Update LIC_FILES_CHKSUM for cpupower as
the COPYING file which is used for LIC_FILES_CHKSUM
has been changed in below commit:
commit bf02d491237eea10290bd379bf7fc8c37ac6c3b4
Author: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Date: Fri Mar 23 06:51:06 2018 -0300
COPYING: use the new text with points to the license files
Now that we have a new COPYING file with points to the
Linux license files, replace it with the old content.
This patch does:
1 file changed, 0 insertions(+), 0 deletions(-)
rename COPYING.new => COPYING (100%)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
* (Depends upon a linux-libc-headers patch proposed to oe-core)
* Delete unused patch
* Mark Clang 6.0 as minimum required version
* Do not hardcode python3 interpreter path
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Hongzhi.Song <hongzhi.song@windriver.com>
Cc: Martin Jansa <Martin.Jansa@gmail.com>
we were having static md5 sum but the COPYING file
was very much tied to certain versions of kernel this
makes it fail for several different kernel versions
so lets keep the upstream version of copying file
Signed-off-by: Khem Raj <raj.khem@gmail.com>
COPYING coming from kernel sources but the md5 is static value
saved in recipe does not scale to all kind of machines which may
have different kernel providers filling in, therefore keep a static
copy of COPYING file as well, additionally copy LICENSES directory ( if
it exists) into sources where all the real license texts are living
Document need for clang
Signed-off-by: Khem Raj <raj.khem@gmail.com>
* respect PACKAGECONFIG when setting TEST_LIST
* call the sed in remove_clang_related only when bpf PACKAGECONFIG is
enabled and if ${S}/tools/testing/selftests/bpf/Makefile doesn't exist
then show more useful error message than:
sed: can't read kernel-selftest/1.0-r0/kernel-selftest-1.0/tools/testing/selftests/bpf/Makefile: No such file or directory
because kernels older than 4.10 don't have bpf selftest which was
added in:
5aa5bd14c5
* disable ldflags QA errors, the selftests Makefile explicitly overrides
LDFLAGS to empty:
5aa5bd14c5/tools/testing/selftests/Makefile (L46)
and the vm/Makefile doesn't respect LDFLAGS anyway:
5aa5bd14c5/tools/testing/selftests/vm/Makefile (L17)
so it was causing a lot of errors:
ERROR: kernel-selftest-1.0-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/thuge-gen'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/thuge-gen'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/transhuge-stress'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/transhuge-stress'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/userfaultfd'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/userfaultfd'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/hugepage-shm'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/hugepage-shm'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/on-fault-limit'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/on-fault-limit'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/hugepage-mmap'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/hugepage-mmap'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/compaction_test'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/compaction_test'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/mlock2-tests'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/mlock2-tests'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/map_hugetlb'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/map_hugetlb' [ldflags]
* fix the formatting and useless append
* add dependency on rsync-native as it's used during do_install:
| make: Entering directory 'kernel-selftest/1.0-r0/kernel-selftest-1.0/tools/testing/selftests/vm'
| rsync -a run_vmtests compaction_test hugepage-mmap hugepage-shm map_hugetlb mlock2-tests on-fault-limit thuge-gen transhuge-stress userfaultfd kernel-selftest/1.0-r0/image/usr/kernel-selftest/vm/
| /bin/sh: 1: rsync: not found
| ../lib.mk:24: recipe for target 'install' failed
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
There are some new program added for bpf. So we make corresponding
modifications.
Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
* respect PACKAGECONFIG when setting TEST_LIST
* call the sed in remove_clang_related only when bpf PACKAGECONFIG is
enabled and if ${S}/tools/testing/selftests/bpf/Makefile doesn't exist
then show more useful error message than:
sed: can't read kernel-selftest/1.0-r0/kernel-selftest-1.0/tools/testing/selftests/bpf/Makefile: No such file or directory
because kernels older than 4.10 don't have bpf selftest which was
added in:
5aa5bd14c5
* disable ldflags QA errors, the selftests Makefile explicitly overrides
LDFLAGS to empty:
5aa5bd14c5/tools/testing/selftests/Makefile (L46)
and the vm/Makefile doesn't respect LDFLAGS anyway:
5aa5bd14c5/tools/testing/selftests/vm/Makefile (L17)
so it was causing a lot of errors:
ERROR: kernel-selftest-1.0-r0 do_package_qa: QA Issue: No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/thuge-gen'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/thuge-gen'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/transhuge-stress'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/transhuge-stress'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/userfaultfd'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/userfaultfd'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/hugepage-shm'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/hugepage-shm'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/on-fault-limit'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/on-fault-limit'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/hugepage-mmap'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/hugepage-mmap'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/compaction_test'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/compaction_test'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/mlock2-tests'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/mlock2-tests'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/map_hugetlb'
No GNU_HASH in the elf binary: 'kernel-selftest/1.0-r0/packages-split/kernel-selftest/usr/kernel-selftest/vm/map_hugetlb' [ldflags]
* fix the formatting and useless append
* add dependency on rsync-native as it's used during do_install:
| make: Entering directory 'kernel-selftest/1.0-r0/kernel-selftest-1.0/tools/testing/selftests/vm'
| rsync -a run_vmtests compaction_test hugepage-mmap hugepage-shm map_hugetlb mlock2-tests on-fault-limit thuge-gen transhuge-stress userfaultfd kernel-selftest/1.0-r0/image/usr/kernel-selftest/vm/
| /bin/sh: 1: rsync: not found
| ../lib.mk:24: recipe for target 'install' failed
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
The recipe builds the framework for kernel-selftest. Now, it just
contains two sets of testcase, bpf and vm. We will append more to
this recipe.
The following kernel config fragments must be manually enabled,
i.e. in local.conf, to use this test suite.
KERNEL_FEATURES_append += "features/bpf/bpf.scc \
cfg/debug-kselftest.scc \
features/hugetlb/hugetlb.scc \
"
Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
it needs binaries from glibc-utils, obviously we dont
have this with musl, however in future if we can limit
which binaries are needed from glibc-utils then we might
be able to provide an alternative dependency when using
musl, until then disable it
Signed-off-by: Khem Raj <raj.khem@gmail.com>
The bpftool allows for inspection and simple manipulation of
eBPF programs and maps, so common in the kernel selftests.
Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
It is an efficient and necessary tool to reflect the status of X86
processors. Turbostat reports processor topology, frequency, idle
power-state statistics, temperature and power on X86 processors.
Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Several Broadcom Bluetooth USB dongles require firmware to be loaded.
This recipe provides the firmware for BCM20702, BCM20703, BCM43142,
BCM4335, BCM4350, BCM4356 and BCM4371 based devices.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Change path of minicoredumper on init/service script to /usr/sbin.
Since the commit "relocate admin-binaries to sbin" on minicoredumper,
minicoredumper binaries are installed on /usr/sbin directory instead
of /usr/bin.
src/minicoredumper/Makefile.am: sbin_PROGRAMS = minicoredumper
Signed-off-by: Christophe Priouzeau <christophe.priouzeau@st.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
The sysv initscript and systemd service assumes minicoredumper is
installed in /usr/bin/. In our case minicoredumper is installed in
/usr/sbin/ by default. Therefore, fix this path.
Signed-off-by: Pierre-Jean TEXIER <texier.pj2@gmail.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Add gettext-native to DEPENDS to fix the following build error:
MSGFMT cpupower/1.0-r0/cpupower-1.0/po/fr.gmo
make: msgfmt: Command not found
Signed-off-by: Liwei Song <liwei.song@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
kpatch is a Linux dynamic kernel patching infrastructure
which allows you to patch a running kernel without
rebooting or restarting any processes
Currently it is enabled and tested on x86-64 systems,
although can be extended to PPC64 as well.
Signed-off-by: Ruslan Bilovol <rbilovol@cisco.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
1)Upgrade crash from 7.1.9 to 7.2.0.
2)Delete 0004-crash-fix-build-failure-with-mips.patch, since it is integrated upstream.
Signed-off-by: Huang Qiyu <huangqy.fnst@cn.fujitsu.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
oe-core will focus on perf as a better alternative moving forward. Existing
users of oprofile are encouraged to move to perf, but for now can be unblocked
with oprofile moved to meta-oe.
Signed-off-by: Denys Dmytriyenko <denys@ti.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
cpupower is a tool to show and set processor power related values.
In addition, it allows to run in-kernel selftests intel_pstate test.
The recipe is based on the initial work from Roy Li <rongqing.li@windriver.com>:
https://patchwork.openembedded.org/patch/118911/
Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
COPYING file changed since copyright is now assined to linutronix from Erricson
Fix build on arm
Fixes error like
corestripper.c:1245:4: error: format specifies type 'unsigned long' but the arg
ument has type 'long long' [-Werror,-Wformat]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* as PNBLACKLIST message says, these recipes are blacklisted for long
time and nobody showed any interest to fix them
* remove all unused .patch and .inc files as well
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Remove add-proper-format-string-to-print-a-str.patch since it had been
merged in upstream.
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
This is because when using fortify warnings we need to have
some level of optimization, while we append warnings to CC
we dont do the same for optimization, which results in compile
failures when doing build with hardened flags
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
agent-proxy is a simple, small proxy which is intended
for use with kgdb, or gdbserver type connections where
you want to share a text console and a debug session.
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
When build crash with mips:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mips-linux-nat.c:157:1: error: conflicting types for 'ps_get_thread_area'
ps_get_thread_area (const struct ps_prochandle *ph,
^~~~~~~~~~~~~~~~~~
In file included from gdb_proc_service.h:26:0,
from mips-linux-nat.c:32:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This problem have been fixed on intel and arm plantform, we can use the
similar approch to fix it on mips.
Signed-off-by: Dengke Du <dengke.du@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
1. Upgrade crash to fix build failure with glibc 2.25.
2. Add the "id" to HOSTTOOLS in meta-oe/layer.conf
Signed-off-by: Dengke Du <dengke.du@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* Clarify licensing and switch to github for fetching
* Delete empty /var/run
Fixes
minicoredumper-2.0.0: minicoredumper: Files/directories were installed but not shipped in any package:
/run
Signed-off-by: Khem Raj <raj.khem@gmail.com>
* based on discussion in pndeprecated thread:
https://patchwork.openembedded.org/patch/137573/
update the messages to warn possible users that the
recipe will be removed before the end of the next development
cycle (before Yocto 2.4 is released).
* updated with:
sed -i 's/^\(PNBLACKLIST.*".*\)"/\1 - the recipe will be removed on 2017-09-01 unless the issue is fixed"/g' `git grep PNBLACKLIST | sed 's/:.*//g' | sort -u | xargs`
* then noticed couple recipes being blacklisted only based on
DISTRO_FEATURES, so removed those:
meta-networking/recipes-support/lksctp-tools/lksctp-tools_1.0.17.bb
meta-oe/recipes-connectivity/bluez/bluez-hcidump_2.5.bb
meta-oe/recipes-connectivity/bluez/bluez4_4.101.bb
meta-oe/recipes-connectivity/bluez/gst-plugin-bluetooth_4.101.bb
meta-oe/recipes-navigation/foxtrotgps/foxtrotgps_1.1.1.bb
meta-oe/recipes-navigation/gypsy/gypsy.inc
meta-oe/recipes-navigation/navit/navit.inc
meta-oe/recipes-support/opensync/libsyncml_0.5.4.bb
* if it isn't fixed by this date, it's fair game to be removed
whenever someone gets around to i
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* Support 4.8 kernel
* Add a patch to fix vmcore compressing for ppc64
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
This avoids a "QA Issue: No GNU_HASH in the elf binary:".
Signed-off-by: Adrian Dudau <adrian.dudau@enea.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* remove tabs which sneaked in since last cleanup
* meta-oe layers are using consistent indentation with 4 spaces, see
http://www.openembedded.org/wiki/Styleguide
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* Add makedumpfile 1.6.0
* Create alias for target such as powerpc as powerpc32
* Remove hardcode CFLAGS
* Add CFLAGS_COMMON to instead of CFLAGS so can flexibly
customize CFLAGS and not hardcode the CFLAGS as previously
* Forcibly to link dynamic library as the poky build
system doesn't build static library by default
Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
minicoredumper provides an alternate core dump facility for Linux
to allow minimal and customized crash dumps
Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
base_contains() is a compatibility wrapper and may warn in the future, so
replace all instances with bb.utils.contains().
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
This patch adds the cross package for the crash recipe. I've built and
tested crash-cross for ARM on x86_64 host only.
The way to pass GDB_CONF_FLAGS and --target to GDB build without
removing -m32 from CFLAGS is awkward but that is what I could come up
with, without changing the patch files included with the recipe or
breaking target and native builds. Anyone got any ideas on how to
better do this?
Thanks,
Goran
Signed-off-by: Goran Cengic <cengic@gmail.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Add crash-native package.
* append EXTRA_OEMAKE option to find ncurses library
* pass right install DESTDIR
Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* some layers already have recipes for linux-backports
* don't know about anyone still using this and fails in default setups
| make -C /home/jenkins/oe/world/shr-core/tmp-glibc/work-shared/qemuarm/kernel-source M=/home/jenkins/oe/world/shr-core/tmp-glibc/work/qemuarm-oe-linux-gnueabi/compat-wireless-all/3.6.8-r1.0/compat-wireless-3.6.8-1 modules
| make[1]: Entering directory `/home/jenkins/oe/world/shr-core/tmp-glibc/work-shared/qemuarm/kernel-source'
| make[2]: Entering directory `/home/jenkins/oe/world/shr-core/tmp-glibc/work-shared/qemuarm/kernel-build-artifacts'
| /home/jenkins/oe/world/shr-core/tmp-glibc/work/qemuarm-oe-linux-gnueabi/compat-wireless-all/3.6.8-r1.0/compat-wireless-3.6.8-1/config.mk:21: *** "ERROR: compat-wireless by default supports kernels >= 2.6.24, try enabling only one driver though". Stop.
| make[2]: *** [_module_/home/jenkins/oe/world/shr-core/tmp-glibc/work/qemuarm-oe-linux-gnueabi/compat-wireless-all/3.6.8-r1.0/compat-wireless-3.6.8-1] Error 2
| make[2]: Leaving directory `/home/jenkins/oe/world/shr-core/tmp-glibc/work-shared/qemuarm/kernel-build-artifacts'
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Upgrade crash from 7.1.2 to 7.1.3.
Add gdb source tarball and don't fetch and extract it during do_compile.
And do some format tweaks.
Exclude mips64 from COMPATIBLE_HOST which is not supported. And update
ARCH setting for arm64, ppc64 and mips32.
Add patch to enable parallel make for gdb. And don't write crash.target
which causes rebuild fails.
Backport patches to fix compile failures.
Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* building ktap-module without elfutils fails with:
ktap-module/0.4-r0/git/Makefile:107: No libelf found, disables symbol resolving, please install elfutils-libelf-devel/libelf-dev
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* even if it makes sense in this case, don't give bad example for other people to
copy & paste to other recipes, kernel modules should be only recommended, so that
it still works fine if someone includes the module inside kernel image
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* set PV so that it shows git revision and also automatically rebuilds them
when SRCREV is changed
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* this .inc file wasn't working since oe-core commit:
commit 106dab2fd0321e6b4e77b40111e59a3a31d329d4
Author: Richard Purdie <richard.purdie@linuxfoundation.org>
Date: Fri Dec 19 17:46:27 2014 +0000
Subject: kernel: Fix non linux-yocto builds
* Fixes following do_configure error
| NOTE: make oldconfig
| make: *** No rule to make target `oldconfig'. Stop.
| ERROR: oe_runmake failed
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* it's possible to exclude ktap-module dependency from siggen, but
then we would need to exclude virtual/kernel and that doesn't work
we would need to list all posisble providers as
ktap->linux-yocto
ktap->linux-foo
....
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Changes:
- rename SUMMARY with length > 80 to DESCRIPTION
- rename DESCRIPTION with length < 80 to (non present tag) SUMMARY
- drop final point character at the end of SUMMARY string
- remove trailing whitespace of SUMMARY line
Note: don't bump PR
Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
libelf (elfutils) is required for resolving symbols in DSO and for sdt (taken
from ktap docs). The earlier v0.4 recipe built ktap against libelf if it was
found, thus enable it per default.
FFI needs to be enabled for both userspace and kernel module. Currently, it is
only supported for x86_64 (enforced when building ktap-module).
Signed-off-by: Anders Darander <anders@chargestorm.se>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
When ktap made the release announcement, the tag v0.3 seems to have moved. Set the
correct SRCREV for the announced v0.3.
Signed-off-by: Anders Darander <anders@chargestorm.se>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Ktap is a new scripting dynamic tracing tool for Linux.
>From kernel v3.13 it'll live inside the kernel tree, but for earlier kernels,
this recipe will be usefull.
Signed-off-by: Anders Darander <anders@chargestorm.se>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* This change is only aesthetic (unlike indentation in Python
tasks).
* Some recipes were using tabs.
* Some were using 8 spaces.
* Some were using mix or different number of spaces.
* Make them consistently use 4 spaces everywhere.
* Yocto styleguide advises to use tabs (but the only reason to keep
tabs is the need to update a lot of recipes). Lately this advice
was also merged into the styleguide on the OE wiki.
* Using 4 spaces in both types of tasks is better because it's less
error prone when someone is not sure if e.g.
do_generate_toolchain_file() is Python or shell task and also allows
to highlight every tab used in .bb, .inc, .bbappend, .bbclass as
potentially bad (shouldn't be used for indenting of multiline
variable assignments and cannot be used for Python tasks).
* Don't indent closing quote on multiline variables
we're quite inconsistent wheater it's first character on line
under opening quote or under first non-whitespace character in
previous line.
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Acked-by: Koen Kooi <koen@dominion.thruhere.net>
* use INC_PR
* fix RDEPENDS
* use normal PV
* move checksums from .inc to .bb
* upgrade, because old version fails to build with a lot of errors like this:
compat-wireless-3.5-rc5-1/include/linux/compat-3.5.h:102:8: error: redefinition of 'struct tc_fq_codel_xstats'
* 3.5.4-1, 3.6.8-1 can failed when kernel option is missing:
| compat-wireless-all/3.5.4-r1.0/compat-wireless-3.5.4-1/drivers/net/ethernet/broadcom/b44.c:2342:2:
error: implicit declaration of function 'ssb_pcihost_register' [-Werror=implicit-function-declaration]
| cc1: some warnings being treated as errors
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
This recipe was based on the compat-wireless.inc recipe from openembedded-classic
at commit 53784a5e2622582ce5e2ffb91bbdb573503ed75e
The .inc is there in order to make it possible to have such recipes:
$ cat compat-wireless-ath_0.bb
include compat-wireless.inc
do_configure() {
cd ${S}
./scripts/driver-select ath
}
0001-ath5k-fix-compilation-without-CONFIG_PCI.patch will have to be submitted upstream
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
* in my env I have 7 copies now
./meta-smartphone/meta-htc/recipes-kernel/linux/linux.inc
./meta-smartphone/meta-nokia/recipes-kernel/linux/linux.inc
./meta-smartphone/meta-openmoko/recipes-kernel/linux/linux.inc
./meta-smartphone/meta-samsung/recipes-kernel/linux/linux.inc
./meta-smartphone/meta-palm/recipes-kernel/linux/linux.inc
./meta-ti/recipes-kernel/linux/linux.inc
./meta-handheld/recipes-kernel/linux/linux.inc
meta-smartphone's are 100% identical, meta-handheld is slightly
different (ARM_KEEP_OABI can be set in recipe after require .inc) and
meta-ti seems like much older version of linux.inc
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
* packaging split from meta-openembedded has been accepted in oe-core
* as per commit id 1f40a5486f703684c5d1d7360ef3cbdf75577495
Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
